[hist] Implement initial RAxes#19596
Merged
hahnjo merged 5 commits intoroot-project:masterfrom Aug 14, 2025
Merged
Conversation
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 309d88a. ♻️ This comment has been updated with latest results. |
hageboeck
approved these changes
Aug 11, 2025
jblomer
reviewed
Aug 12, 2025
Contributor
jblomer
left a comment
jblomer
left a comment
There was a problem hiding this comment.
In principle LGTM. Some suggestions.
It only takes a single argument, avoid accidental construction from any std::vector<double>.
This first version supports RRegularAxis and RVariableBinAxis and exposes only ComputeTotalNumBins and ComputeGlobalIndex.
This method will be extensively used during histogram filling, so it should be fast.
This may cause a minor hit in the microbenchmark (for two dimensions), but this will likely be within noise together with future changes to check the argument types for a given axis type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This first version supports
RRegularAxisandRVariableBinAxisand exposes onlyComputeTotalNumBinsandComputeGlobalIndex.