[tree] fix TTree::BuildIndex with a formula containing variable array index#19619
Merged
vepadulano merged 3 commits intoroot-project:masterfrom Oct 23, 2025
Merged
[tree] fix TTree::BuildIndex with a formula containing variable array index#19619vepadulano merged 3 commits intoroot-project:masterfrom
vepadulano merged 3 commits intoroot-project:masterfrom
Conversation
ferdymercury
changed the title
Test Results 22 files 22 suites 3d 18h 19m 59s ⏱️ Results for commit bf90040. ♻️ This comment has been updated with latest results. |
pcanal
reviewed
Aug 12, 2025
pcanal
reviewed
Aug 12, 2025
ferdymercury
commented
Aug 13, 2025
ferdymercury
commented
Aug 13, 2025
ferdymercury
commented
Aug 13, 2025
ferdymercury
force-pushed
the
varindex
branch
from
2e974a7 to
6168e4b
Compare
vepadulano
requested changes
Oct 20, 2025
Member
vepadulano
left a comment
vepadulano
left a comment
There was a problem hiding this comment.
Sorry for coming back to this PR now, I would like to ask for a couple of clarifications.
vepadulano
approved these changes
Oct 20, 2025
Member
vepadulano
left a comment
vepadulano
left a comment
There was a problem hiding this comment.
Thanks! I believe the changes are good! Before merging I would also wait for approval by @pcanal
ferdymercury
force-pushed
the
varindex
branch
from
6168e4b to
43b02ec
Compare
ferdymercury
force-pushed
the
varindex
branch
from
43b02ec to
bf90040
Compare
vepadulano
approved these changes
Oct 22, 2025
Member
vepadulano
left a comment
vepadulano
left a comment
There was a problem hiding this comment.
Just wanted to confirm approval after latest push
pcanal
approved these changes
Oct 22, 2025
Collaborator
Author
|
Green now :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
fyi @amete @midnightpride
Fixes #11883
Checklist: