[tmva][sofie] Improved std::tanh with exponential formula #19740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanjibansg
approved these changes
Aug 25, 2025
| @@ -6,6 +6,8 @@ | |||
| #include "TMVA/RModel.hxx" | |||
|
|
|||
| #include <sstream> | |||
| #include <vector> | |||
| #include <string> | |||
There was a problem hiding this comment.
why do we need to include the vector and <string> libraries here?
Test Results 21 files 21 suites 3d 12h 14m 15s ⏱️ For more details on these failures, see this check. Results for commit d22aab5. |
olia110
force-pushed
the
feature/tanh-improvement
branch
from
d22aab5 to
5e39de9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
Checklist:
This PR fixes #