Skip to content

[core] fix getenv namespace error with libc++ #19864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 10, 2025
Merged

[core] fix getenv namespace error with libc++ #19864

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9cdbeb0
[core] fix getenv namespace error with libc++
ferdymercury Sep 10, 2025
0c1f275
Use std::getenv consistently, and modernize C headernames
ferdymercury Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions core/foundation/src/FoundationUtils.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@

#include <algorithm>
#include <cassert>
#include <cstdlib>

#include <errno.h>
#include <string.h>
Expand Down Expand Up @@ -150,7 +151,7 @@ const std::string& GetFallbackRootSys() {

#ifdef ROOTPREFIX
static bool IgnorePrefix() {
static bool ignorePrefix = ::getenv("ROOTIGNOREPREFIX");
static bool ignorePrefix = std::getenv("ROOTIGNOREPREFIX");
return ignorePrefix;
}
#endif
Expand All @@ -164,7 +165,7 @@ const std::string& GetRootSys() {
#endif
static std::string rootsys;
if (rootsys.empty()) {
if (const char* envValue = ::getenv("ROOTSYS")) {
if (const char* envValue = std::getenv("ROOTSYS")) {
rootsys = envValue;
// We cannot use gSystem->UnixPathName.
ConvertToUnixPath(rootsys);
Expand Down
Loading