[ntuple] automatic evolution of nullable fields#19966
Merged
jblomer merged 2 commits intoroot-project:masterfrom Oct 8, 2025
Merged
[ntuple] automatic evolution of nullable fields#19966jblomer merged 2 commits intoroot-project:masterfrom
jblomer merged 2 commits intoroot-project:masterfrom
Conversation
Test Results 21 files 21 suites 3d 18h 15m 27s ⏱️ For more details on these failures, see this check. Results for commit ef745c6. ♻️ This comment has been updated with latest results. |
silverweed
reviewed
Sep 24, 2025
enirolf
reviewed
Sep 24, 2025
Contributor
enirolf
left a comment
enirolf
left a comment
There was a problem hiding this comment.
Nice! I have two minor documentation suggestions and a question, see below.
jblomer
force-pushed
the
ntuple-evolution-nullable
branch
from
4808ccf to
edc8d6d
Compare
jblomer
force-pushed
the
ntuple-evolution-nullable
branch
from
edc8d6d to
5936f59
Compare
jblomer
force-pushed
the
ntuple-evolution-nullable
branch
from
5936f59 to
fc079c2
Compare
jblomer
force-pushed
the
ntuple-evolution-nullable
branch
from
fc079c2 to
fcb5647
Compare
jblomer
force-pushed
the
ntuple-evolution-nullable
branch
from
fcb5647 to
ef745c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conversion between
std::unique_ptr<T>andstd::optional<T>as well asT-->std::unique_ptr|std::optional<T>.