[ntuple] finalize automatic schema evolution between collections#20007
Merged
jblomer merged 4 commits intoroot-project:masterfrom Oct 8, 2025
Merged
[ntuple] finalize automatic schema evolution between collections#20007jblomer merged 4 commits intoroot-project:masterfrom
jblomer merged 4 commits intoroot-project:masterfrom
Conversation
jblomer
force-pushed
the
ntuple-evolution-collections
branch
from
0c12fd5 to
30e1202
Compare
Test Results 21 files 21 suites 3d 10h 49m 18s ⏱️ For more details on these failures, see this check. Results for commit f18748b. ♻️ This comment has been updated with latest results. |
jblomer
force-pushed
the
ntuple-evolution-collections
branch
from
30e1202 to
f420cd5
Compare
hahnjo
approved these changes
Sep 30, 2025
Member
hahnjo
left a comment
hahnjo
left a comment
There was a problem hiding this comment.
Looks mostly good; two questions inline because I forgot our discussions again...
jblomer
force-pushed
the
ntuple-evolution-collections
branch
from
f420cd5 to
450d19b
Compare
Collection items must have "_0" as item field name, which can be violated in RVectorField::CreateUntyped().
jblomer
force-pushed
the
ntuple-evolution-collections
branch
from
450d19b to
f18748b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.