[Math] Migrate from Vc to std::experimental::simd - show what happens for all platforms with vecccore=ON#20068
Closed
guitargeek wants to merge 7 commits intoroot-project:masterfrom
Closed
[Math] Migrate from Vc to std::experimental::simd - show what happens for all platforms with vecccore=ON#20068guitargeek wants to merge 7 commits intoroot-project:masterfrom
std::experimental::simd - show what happens for all platforms with vecccore=ON#20068guitargeek wants to merge 7 commits intoroot-project:masterfrom
Conversation
Test Results 2 files 2 suites 5h 47m 53s ⏱️ For more details on these failures, see this check. Results for commit fd53784. ♻️ This comment has been updated with latest results. |
guitargeek
force-pushed
the
ci_demo
branch
7 times, most recently
from
10eebdc to
af828a2
Compare
guitargeek
changed the title
std::simd - show what happens for all platforms with vecccore=ON
guitargeek
changed the title
std::simd - show what happens for all platforms with vecccore=ONstd::simd - show what happens for all platforms with vecccore=ON
guitargeek
changed the title
std::simd - show what happens for all platforms with vecccore=ONstd::experimental::simd - show what happens for all platforms with vecccore=ON
guitargeek
force-pushed
the
ci_demo
branch
2 times, most recently
from
eda7a30 to
d44f801
Compare
… type The GenVector classes are also to be able to accept `std::experimental::simd types` as template parameters, while dropping compatibility with Vc types to keep the overall support burden low. However, if people actually used GenVector with Vc, we can easily fix this for them with some `constexpr` branching in the templated GenVector classes. It's just not worth to do this at this point, as I'm not aware of anyone who used GenVector with Vc.
Always use `std::experimental::simd` as the backend for VecCore if the platform supports it. Otherwise, we drop support for the TMath and TFormula vectorization features that VecCore enables.
We have no test coverage on Linux for these options right now. We don't want to necessarily enable them in the release at this point, but enabling them on the `march=native` build is the perfect opportunity to test the TFormula and TMath features that VecCore enables, in particular with the `std::simd` backend.
Some of the shortcuts represent the same `cmath` functions that are used to implement TMath anyway.
Now that we always use the `std::simd` backend of VecCore, we don't need to use `vecCore::math` anymore, because all the functions from `cmath` that VecCore wraps are also implemented for `std::simd`.
Contributor
Author
|
Not needed anymore: with the new suggestion to also drop the VecCore dependency, we can anyway enable the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge. This is just for a demo CI run