Use stressGraphics for SVG content tests - #20118
Merged
Merged
Conversation
Test Results 22 files 22 suites 3d 21h 25m 45s ⏱️ For more details on these failures, see this check. Results for commit bd5f5c2. ♻️ This comment has been updated with latest results. |
couet
approved these changes
Oct 16, 2025
linev
force-pushed
the
stress_svg
branch
12 times, most recently
from
October 21, 2025 13:59
4b7c1fe to
5f19049
Compare
Create SVG files in compact or full form and then compare them with provided reference files
In SVG mode use only GMT time to have reproducible time on all platforms in all time zones. To exclude variation of %Z output of strftime on different platforms just always printout GMT directly
Avoid deviation in graphics due to fitting
If relative position changes only by small value - ignore this change. Let exclude rounding effects for testing when compact SVG form created
linev
marked this pull request as ready for review
October 23, 2025 07:58
couet
approved these changes
Oct 23, 2025
First provide SVG mode in stressGraphics to let generate only SVG files. Such SVG created in compact form which is now provided with TSVG class. When check reference files, compare line by line and print difference Some canvases disabled because of huge size which should be optimized first Content of reference SVG files must be exactly the same on all platforms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stressGraphicsalready has different graphics objects so one can test them in SVG generation.But not only size of produced SVG, but also exact content must match.
So add reference SVG files, created in compact mode, and check that they remains the same.
There are very few "known" problem why SVG files differ on different platforms.
Like time axis in tgaxis4() test.
Also several tests were disabled while producing too big SVG file - which can be changed in the future.
But many issues were resolved with #20131, #20143, #20144
After PR is merged one will have exact testing of how ROOT graphics paint objects.