[gaxis] do not paint (sometime) first and last tick twice#20129
Merged
linev merged 2 commits intoroot-project:masterfrom Oct 17, 2025
Merged
[gaxis] do not paint (sometime) first and last tick twice#20129linev merged 2 commits intoroot-project:masterfrom
linev merged 2 commits intoroot-project:masterfrom
Conversation
If position of first or last tick does not match exactly visible axis range, extra first and extra last tick was painted. While such matching can suffer from float arithmetic uncertanty, on some platforms extra ticks was painted and on others not. This was actually main reason for light variation of PS file size on different platforms. Now simply do not paint first and last tick again in no case.
In stressGraphics created PS files are smaller And roottest/root/treedraw/hsimple.ps.ref also removes that extra tick
couet
approved these changes
Oct 17, 2025
Test Results 21 files 21 suites 3d 18h 17m 56s ⏱️ For more details on these failures, see this check. Results for commit ec42e64. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If position of first or last major tick does not match exactly visible axis range,
first and last ticks were painted extra again.
While such visible range matching can suffer from float arithmetic uncertainty,
on some platforms extra ticks were painted and on others not.
This is actually main reason for variation of PS file sizes on different platforms in
stressGraphics.Now simply do not paint first and last tick again.
Adjust ref files for tests