[tmva][sofie] install onnxscript from within LinearModelGenerator#20130
Closed
sanjibansg wants to merge 2 commits intoroot-project:masterfrom
Closed
[tmva][sofie] install onnxscript from within LinearModelGenerator#20130sanjibansg wants to merge 2 commits intoroot-project:masterfrom
sanjibansg wants to merge 2 commits intoroot-project:masterfrom
Conversation
vepadulano
requested changes
Oct 17, 2025
Member
vepadulano
left a comment
vepadulano
left a comment
There was a problem hiding this comment.
Sorry but I believe this is really not good practice
Test Results 22 files 22 suites 3d 23h 51m 16s ⏱️ For more details on these failures, see this check. Results for commit 701873b. ♻️ This comment has been updated with latest results. |
Collaborator
Author
Yes, this might not be very good, we are also investigating this more, since there are some other cases failing for this test. |
Contributor
|
Superseded by #20149. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tries to install onnxscript from within the
LinearModelGenertor.pyfile if the package does not already exist to avoid failures in the CI.