[graf2d] allow zero-margins between pads and respect color for negative margins

[ferdymercury]

This Pull request:

Changes or fixes:

Fixes #20138

fyi @rlalik

Checklist:

• tested changes locally
• updated the docs (if necessary)

[github-actions]

Test Results

    22 files      22 suites   3d 19h 34m 57s ⏱️
 3 701 tests  3 701 ✅ 0 💤 0 ❌
79 471 runs  79 471 ✅ 0 💤 0 ❌

Results for commit b6cbdf3.

♻️ This comment has been updated with latest results.

[rlalik]

I didn't test the PR code but this seems to be the solution. However, since this was broken and is being fixed, I would like to propose some change. Current behavior is that, when setting non-zero positive margin, the margin is applied to all pads, also on the outer edges, not only between pads. But sometimes one wants to increase the margin to separate the pads, for better visibility or so, but actually we don't want to increase the margin on the outer edges, where there is no other pad to keep distance from.

So my proposition would be, when the margin is positive, have all margins set - this will be the default behavior, compatible with 99% existing code. But when the margin value is negative, only the inner margin between pads are set, and the outer margin are kept 0. Setting margin to be 0 removes the margins between pads.

A such implementation would be flexible I think for almost all cases.

So with canvas->Divide(2, 2, -0.02, -0.02) I would get something like this:

and with canvas->Divide(2, 2, 0.02, -0.02) I would get something like this:

Could it be done?

[ferdymercury]

@rlalik would you like to propose a code modification for the new feature you are mentioning? It should go just below the if statement I modified

[rlalik]

@rlalik would you like to propose a code modification for the new feature you are mentioning? It should go just below the if statement I modified

So I propose that this gets merged and then I submit PR with my proposed change to add my requested feature.

[linev]

I reopen PR to restart CI

[ferdymercury]

CI green now :)

[rlalik]

Ok, I made tests with following macro:

{
    TCanvas * can_0 = new TCanvas("can_0", "can_0", 200, 200, 200, 200);
    can_0->Divide(2, 2, 0.1, 0.1, 2);
    can_0->Draw();

    TCanvas * can_1 = new TCanvas("can_1", "can_1", 408, 200, 200, 200);
    can_1->Divide(2, 2, 0.0, 0.1, 2);
    can_1->Draw();

    TCanvas * can_2 = new TCanvas("can_2", "can_2", 616, 200, 200, 200);
    can_2->Divide(2, 2, 0.1, 0.0, 2);
    can_2->Draw();

    TCanvas * can_3 = new TCanvas("can_3", "can_3", 824, 200, 200, 200);
    can_3->Divide(2, 2, 0.0, 0.0, 2);
    can_3->Draw();

    TCanvas * can_4 = new TCanvas("can_4", "can_4", 200, 432, 200, 200);
    can_4->Divide(2, 2, -0.1, -0.1, 2);
    can_4->Draw();

    TCanvas * can_5 = new TCanvas("can_5", "can_5", 408, 432, 200, 200);
    can_5->Divide(2, 2, 0.1, -0.1, 2);
    can_5->Draw();

    TCanvas * can_6 = new TCanvas("can_6", "can_6", 616, 432, 200, 200);
    can_6->Divide(2, 2, -0.1, 0.1, 2);
    can_6->Draw();

    TCanvas * can_7 = new TCanvas("can_7", "can_7", 824, 432, 200, 200);
    can_7->Divide(2, 2, 0.1, 0.1, 2);
    can_7->Draw();
}

Canvases 4...6 still seems to behave odd with negative margin value. I didn't yet implement my feature, this is the version after this PR merge.

I will try to implement my negative margins.