Skip to content

[hist] disallow equal bin edges#20186

Merged
vepadulano merged 2 commits intoroot-project:masterfrom
ferdymercury:patch-4
Oct 24, 2025
Merged

[hist] disallow equal bin edges#20186
vepadulano merged 2 commits intoroot-project:masterfrom
ferdymercury:patch-4

Conversation

@ferdymercury
Copy link
Collaborator

Fixes #20185

credit goes to VanyaBelyaev

@ferdymercury ferdymercury requested a review from lmoneta as a code owner October 24, 2025 08:29
Fixes root-project#20185

credit goes to VanyaBelyaev
@vepadulano
Copy link
Member

Thank @ferdymercury for the PR! I took the liberty of adding a test to increase the coverage.

@ferdymercury
Copy link
Collaborator Author

Thank @ferdymercury for the PR! I took the liberty of adding a test to increase the coverage.

Thanks.

Side note: with this PR we are also making it equal to

if (fBinEdges[i - 1] >= fBinEdges[i]) {

@github-actions
Copy link

Test Results

    22 files      22 suites   3d 11h 10m 38s ⏱️
 3 701 tests  3 701 ✅ 0 💤 0 ❌
79 468 runs  79 468 ✅ 0 💤 0 ❌

Results for commit f82de3d.

Copy link
Member

@vepadulano vepadulano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@vepadulano vepadulano merged commit d312062 into root-project:master Oct 24, 2025
27 checks passed
@ferdymercury ferdymercury deleted the patch-4 branch October 24, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TAxis constructor from bin edges silently accepts the same edges in the list

2 participants