[Python] Avoid need for manual __len__ pythonizations by implementing size()
#20195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guitargeek
requested review from
dpiparo,
lmoneta,
pcanal and
vepadulano
as code owners
We prefer C++ code that get pythonized automatically by the heuristics in `cppyy`. One of these heuristics is the automatic implementation of `__len__` in terms of the `size()` method on the C++ side.
Test Results 22 files 22 suites 3d 23h 44m 12s ⏱️ For more details on these failures, see this check. Results for commit 283d79d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We prefer C++ code that get pythonized automatically by the heuristics in
cppyy. One of these heuristics is the automatic implementation of__len__in terms of thesize()method on the C++ side.