Skip to content

Conversation

@ferdymercury
Copy link
Collaborator

@ferdymercury ferdymercury commented Oct 26, 2025

This is related to #20174 and the discussion in #20176

Should we completely disallow infinite bin edges, since it violates a bit the assumptions of under and overflow bins? (As well as complicates the implementation of GetBinCenter, Low and Up Edge, etc). And the workaround is quite easy, just setting 1e30 / 1-e30 as variable bin edge.

Or should we only allow inf for variable bin edges, and not for fixed binwidth since there it does not make sense?

@ferdymercury ferdymercury marked this pull request as ready for review October 26, 2025 10:39
@ferdymercury ferdymercury requested a review from pcanal as a code owner October 26, 2025 12:02
@ferdymercury ferdymercury changed the title [hist] raise error of badly sorted edges as with variable binwidth [hist] raise error of badly sorted edges as with variable binwidth, and check for inf/nan Oct 26, 2025
@ferdymercury ferdymercury requested a review from dpiparo as a code owner October 26, 2025 12:55
@ferdymercury ferdymercury marked this pull request as draft October 26, 2025 13:02
@github-actions
Copy link

Test Results

    22 files      22 suites   3d 17h 34m 20s ⏱️
 3 701 tests  3 649 ✅   1 💤    51 ❌
79 426 runs  78 071 ✅ 275 💤 1 080 ❌

For more details on these failures, see this check.

Results for commit 7a477d3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant