[hist] raise error of badly sorted edges as with variable binwidth, and check for inf/nan #20201
+61
−29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #20174 and the discussion in #20176
Should we completely disallow infinite bin edges, since it violates a bit the assumptions of under and overflow bins? (As well as complicates the implementation of GetBinCenter, Low and Up Edge, etc). And the workaround is quite easy, just setting 1e30 / 1-e30 as variable bin edge.
Or should we only allow inf for variable bin edges, and not for fixed binwidth since there it does not make sense?