[graphics] Implement TGraphPolar::SavePrimitive#20244
Merged
linev merged 5 commits intoroot-project:masterfrom Nov 5, 2025
Merged
[graphics] Implement TGraphPolar::SavePrimitive#20244linev merged 5 commits intoroot-project:masterfrom
linev merged 5 commits intoroot-project:masterfrom
Conversation
linev
requested review from
couet,
dpiparo,
lmoneta and
pcanal
as code owners
couet
approved these changes
Oct 30, 2025
linev
changed the title
Test Results 22 files 22 suites 4d 1h 37m 49s ⏱️ For more details on these failures, see this check. Results for commit b5479b7. |
One also need to handle TGraphPolargramm which used to paint axes
In many constructors nullptr can be used if array is empty or contains only 0. So to save space in the stored script just return "nullptr" as result of the method or "<vectname>.data()" as string. So produced string can be used as-is when create constructor signature
linev
force-pushed
the
save_graphpolar
branch
from
b5479b7 to
aaf135a
Compare
Member
Author
|
PR was ok before, only stressGraphics can have problem which I want to fix fix next PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was completely missing before.
Extend functionality of
SavePrimitiveVectorto handle empty arrays or arrays with only zeroswhich can be replaced by "nullptr" in many constrctors like in
TGraphErrors.Use this functionality in meaningful places.
Fixes issue discovered with #20216