[tutorials] Return void instead of TCanvas* in histogram tutorials#20285
Merged
siliataider merged 1 commit intoroot-project:masterfrom Nov 6, 2025
Merged
[tutorials] Return void instead of TCanvas* in histogram tutorials#20285siliataider merged 1 commit intoroot-project:masterfrom
siliataider merged 1 commit intoroot-project:masterfrom
Conversation
hahnjo
requested changes
Nov 4, 2025
Member
hahnjo
left a comment
There was a problem hiding this comment.
Tutorials are run as part of the CI, so I would argue the PR should not be marked [skip-ci] and only discover problems after the merge (it happened in the past)
linev
requested changes
Nov 5, 2025
Member
linev
left a comment
There was a problem hiding this comment.
Also please start CI - some tutorials used for testing, which rely on the fact that non-zero value returned by such tutorial.
Member
81233b5 to
7f1977d
Compare
Member
|
Now looks better - but let see CI first |
Test Results 21 files 21 suites 3d 16h 33m 17s ⏱️ Results for commit c627f1e. ♻️ This comment has been updated with latest results. |
linev
approved these changes
Nov 5, 2025
Member
linev
left a comment
There was a problem hiding this comment.
Now looks ok. Please wait for CI
hahnjo
approved these changes
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Update the histogram tutorials to return
voidinstead of aTCanvas*, which is also the convention used in other ROOT tutorials.This is required for testing in the Python wheels workflow #19600 since running
root tutorial.Cin this context returns code255, causingpytestto flag the test as failed.See failure message:
Checklist: