[graphics] fix different SavePrimitve problems#20295
Merged
linev merged 10 commits intoroot-project:masterfrom Nov 6, 2025
Merged
[graphics] fix different SavePrimitve problems#20295linev merged 10 commits intoroot-project:masterfrom
linev merged 10 commits intoroot-project:masterfrom
Conversation
linev
requested review from
couet,
dpiparo,
lmoneta and
pcanal
as code owners
couet
approved these changes
Nov 5, 2025
Test Results 19 files 19 suites 3d 3h 31m 22s ⏱️ Results for commit 25d764e. ♻️ This comment has been updated with latest results. |
If no exact init values defined for TAttFill, gStyle configuration is used. So one always have to save fill attributes for such classes
If no exact init values defined for TAttFill, gStyle configuration is used. So one always have to save fill attributes for such classes
If no exact init values defined for TAttFill, gStyle configuration is used. So one always have to save fill attributes for such classes
Allows to configure histogram used for axes drawing
Like in TGraph, store histogram which used for axis painting. Resolves problem that GetHistogram or GetAxis methods force recreation of histogram object and updating the pad.
1. Implement for `TPie` 3d, text, title drawing including interactivity 2. Fix - proper paint axis labels on both sides when pad.fTickx/y = 2 3. Fix - paint frame border mode/size from TCanvas
After fixes in JSROOT several tests works better now
linev
force-pushed
the
fix_save_primitive
branch
from
ef34c98 to
b21b198
Compare
pcanal
reviewed
Nov 5, 2025
pcanal
reviewed
Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gPad->Update()called many time during execution of saved macro