[rbrowser] support xRooNode and rootfit browsing#20527
Open
linev wants to merge 6 commits intoroot-project:masterfrom
Open
[rbrowser] support xRooNode and rootfit browsing#20527linev wants to merge 6 commits intoroot-project:masterfrom
linev wants to merge 6 commits intoroot-project:masterfrom
Conversation
Invoke existing draw function, making pad->cd() first
Test Results 22 files 22 suites 4d 2h 4m 42s ⏱️ For more details on these failures, see this check. Results for commit 0978a16. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I guess, it also can be interesting for @will-cern.
xRooNodeis special object used inxRooBrowserto explore content ofRooWorkspaceTry to use it as well in RBrowser
browsableAPI.There is special
Browsable::RElemententry for xRooNode which holdsshared_ptrand provides class/name/title/isfolder information about it.There is very basic iterator over sub-items. It can be improved to exclude/hide items which should not be seen in the hierarchy.
Try to use xRooNode::Draw() function for display. Works only for some kinds of data - when special objects like TGraph created and add to the pad.
So it is only first draft of the functionality.
Next points to do:
RegisterClass("RooRealVar", "sap-icon://picture");xRooNodeto the canvas while web graphics does not support it. Instead one always should add only supported classes likeTH1/TGraph/RooHist/RooCurve. In ideal case one provide special function which will useTPad*as argument to avoid usage ofgPad.On the long run one should split
xRooNodefunctionality to avoid direct dependency fromTG...andTRootBrowserclasses.On very very long run one can add support of
Browsableclasses in classicalTBrowser.