Skip to content

[CMake] Use output name of library target also for dictionary name#20563

Merged
guitargeek merged 1 commit intoroot-project:masterfrom
guitargeek:issue-15792
Nov 28, 2025
Merged

[CMake] Use output name of library target also for dictionary name#20563
guitargeek merged 1 commit intoroot-project:masterfrom
guitargeek:issue-15792

Conversation

@guitargeek
Copy link
Contributor

Use output name of the library target also for the dictionary name, if the target is defined and the output name is different from the target name. This makes the dictionary and library file names more consistent.

Closes #15792.

Use output name of the library target also for the dictionary name, if
the target is defined and the output name is different from the target
name. This makes the dictionary and library file names more consistent.

Closes root-project#15792.
Copy link
Member

@bellenot bellenot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (once all the builds are green), thanks!
BTW, is there a risk of breaking users' code?

@guitargeek
Copy link
Contributor Author

Thanks! No risk of breaking the users code, because this is only changing behavior for a case that did work before anyway: when the OUTPUT_NAME of the library was different from the target name. Before, the dictionaries could not be found because the filenames didn't match, and now this case also works.

@bellenot
Copy link
Member

Thanks! No risk of breaking the users code, because this is only changing behavior for a case that did work before anyway: when the OUTPUT_NAME of the library was different from the target name. Before, the dictionaries could not be found because the filenames didn't match, and now this case also works.

Cool, thanks Jonas!

@guitargeek guitargeek merged commit 498165d into root-project:master Nov 28, 2025
27 of 32 checks passed
@guitargeek guitargeek deleted the issue-15792 branch November 28, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

root_generate_dictionary should check target OUTPUT_NAME

2 participants