Skip to content

[Geom] Fix compiler warnings in TGDMLWrite#20569

Merged
guitargeek merged 1 commit intoroot-project:masterfrom
guitargeek:warnings_fixup
Nov 28, 2025
Merged

[Geom] Fix compiler warnings in TGDMLWrite#20569
guitargeek merged 1 commit intoroot-project:masterfrom
guitargeek:warnings_fixup

Conversation

@guitargeek
Copy link
Contributor

This follows up on 74e607e, which introduced some compiler warnings that cause the Debian CI to fail.

Same situation as in #20351, where the failures didn't appear in the CI run for the PR that made the changes yet...

This follows up on 74e607e, which introduced some compiler warnings
that cause the Debian CI to fail.
@guitargeek guitargeek self-assigned this Nov 28, 2025
@guitargeek guitargeek requested a review from agheata as a code owner November 28, 2025 21:29
@guitargeek guitargeek added in:Geometry pr:emergency🚨 This PR is fixing breakage, it's urgent and may overtake others labels Nov 28, 2025
Copy link
Member

@pcanal pcanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The git log message would been enhanced by copy/pasted the warning message.

@guitargeek
Copy link
Contributor Author

Sorry, I'm not with my laptop to update this now, and it would be nice to have green nightlies

@guitargeek guitargeek merged commit e48378e into root-project:master Nov 28, 2025
26 of 32 checks passed
@guitargeek guitargeek deleted the warnings_fixup branch November 28, 2025 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in:Geometry pr:emergency🚨 This PR is fixing breakage, it's urgent and may overtake others

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants