[tmva][pymva] Exercise removal of deprecated TMVA PyKeras method#20577
Closed
guitargeek wants to merge 3 commits intoroot-project:masterfrom
Closed
[tmva][pymva] Exercise removal of deprecated TMVA PyKeras method#20577guitargeek wants to merge 3 commits intoroot-project:masterfrom
PyKeras method#20577guitargeek wants to merge 3 commits intoroot-project:masterfrom
Conversation
guitargeek
force-pushed
the
deprecate_pymva_keras
branch
4 times, most recently
from
3e5048f to
c3387d7
Compare
Test Results 22 files 22 suites 4d 8h 20m 11s ⏱️ For more details on these failures, see this check. Results for commit 8627576. ♻️ This comment has been updated with latest results. |
guitargeek
force-pushed
the
deprecate_pymva_keras
branch
2 times, most recently
from
4613b73 to
3dc068d
Compare
The new Keras 3 API broke the existing TMVA `PyKeras` method.
This should work now that the PyKeras method is removed
guitargeek
force-pushed
the
deprecate_pymva_keras
branch
from
3dc068d to
8627576
Compare
guitargeek
changed the title
PyKeras methodPyKeras method
guitargeek
changed the title
PyKeras methodPyKeras method
Contributor
Author
|
Draft PR can be closed, because it was only to show that removal of the PyKeras method would be easy, should be decide to deprecate it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new Keras 3 API broke the existing TMVA
PyKerasmethod.Also exercise the removal in some temporary commits, to check if removing
PyKerasis sufficient to fixtmva-pymva.Alternative to: