Skip to content

makes sure bash executes .bash_profile #20622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
couet merged 4 commits into from
Dec 8, 2025
Merged

makes sure bash executes .bash_profile #20622

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6cb2ebf
makes sure bash executes .bash_profile
Dec 3, 2025
0492629
Add some debugging
Dec 3, 2025
2c8f47d
do not modify the linux part
Dec 8, 2025
d14c589
Mimic what is done for 6.38
Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/root-ci-config/build_root.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,30 +13,30 @@
explicitly appended to the shell log.
e.g. `os.chdir(x)` requires `cd x` to be appended to the shell log """

import argparse
import datetime
import os
import platform
import re
import shutil
import subprocess
import sys
import tarfile
import time

import openstack

from build_utils import (
die,
github_log_group,
load_config,
calc_options_hash,
subprocess_with_log,
subprocess_with_capture,
upload_file,
is_macos
)
import build_utils

Check failure on line 39 in .github/workflows/root-ci-config/build_root.py

View workflow job for this annotation

GitHub Actions / ruff

Ruff (I001) 

.github/workflows/root-ci-config/build_root.py:16:1: I001 Import block is un-sorted or un-formatted

S3CONTAINER = 'ROOT-build-artifacts' # Used for uploads
S3URL = 'https://s3.cern.ch/swift/v1/' + S3CONTAINER # Used for downloads
Expand Down Expand Up @@ -308,6 +308,8 @@
@github_log_group("Node state")
def show_node_state() -> None:
result = subprocess_with_log("""
echo $SHELL
echo $PATH
which cmake
cmake --version
which c++ || true
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/root-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ jobs:
env:
OVERRIDES: ${{ join( matrix.overrides, ' ') }}
CONFIGFILE: '.github/workflows/root-ci-config/buildconfig/${{ matrix.platform }}.txt'
shell: bash
shell: bash -leo pipefail {0}
run: |
set -x

Expand Down Expand Up @@ -465,7 +465,7 @@ jobs:
env:
OVERRIDES: ${{ join( matrix.overrides, ' ') }}
CONFIGFILE: '.github/workflows/root-ci-config/buildconfig/${{ matrix.image }}.txt'
shell: bash
shell: bash -leo pipefail {0}
Copy link
Copy Markdown
Member

@dpiparo dpiparo Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really needed? linux builds do work...

run: |
set -x

Expand Down
Loading