[roottest] Remove unreachable or redundant code from CMakeLists.txt#20630
Merged
guitargeek merged 3 commits intoroot-project:masterfrom Dec 4, 2025
Merged
[roottest] Remove unreachable or redundant code from CMakeLists.txt#20630guitargeek merged 3 commits intoroot-project:masterfrom
guitargeek merged 3 commits intoroot-project:masterfrom
Conversation
guitargeek
added
in:Build System
clean build
ferdymercury
reviewed
Dec 3, 2025
ferdymercury
reviewed
Dec 3, 2025
guitargeek
force-pushed
the
roottest_fixme
branch
2 times, most recently
from
febc0cf to
82fee6d
Compare
guitargeek
force-pushed
the
roottest_fixme
branch
from
82fee6d to
8bbf173
Compare
We should now rely on all ROOT libraries being linked implicitly via other mechanisms, like `find_package(ROOT)`.
Some configuration code branches are unreachable, now that `roottest` has been merged into ROOT. This also applies to the code that finds the Python interpreter and libraries, as Python is unconditionally found as a dependency already in the main `SearchIntalledSoftware.cmake`, even if `pyroot=OFF`. Another example of redundant code was re-setting the compression default. Specifying a separate project name and minimum CMake version is also not necessary anymore.
This has no clear purpose anymore.
guitargeek
force-pushed
the
roottest_fixme
branch
from
8bbf173 to
85616a3
Compare
ferdymercury
approved these changes
Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some configuration code branches are unreachable, now that
roottesthas been merged into ROOT.This also applies to the code that finds the Python interpreter and libraries, as Python is unconditionally found as a dependency already in the main
SearchIntalledSoftware.cmake, even ifpyroot=OFF.Another example of redundant code was re-setting the compression default.
Specifying a separate project name and minimum CMake version is also not necessary anymore.