[tree] Reset fNamesToBranches map in Streamer()#20721
Merged
silverweed merged 2 commits intoroot-project:masterfrom Dec 16, 2025
Merged
[tree] Reset fNamesToBranches map in Streamer()#20721silverweed merged 2 commits intoroot-project:masterfrom
silverweed merged 2 commits intoroot-project:masterfrom
Conversation
When reading, the Streamer() function may reuse the Tree. If the fNamesToBranch map is not invalidated GetBranch() may return stale pointers to freed memory. Fixes root-project#20706
Test Results 21 files 21 suites 3d 21h 41m 11s ⏱️ Results for commit 4667e75. |
This was referenced Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When reading, the Streamer() function may reuse the Tree. If the fNamesToBranch map is not invalidated GetBranch() may return stale pointers to freed memory.
Fixes #20706
Checklist: