ROOTTEST_COMPILE_MACRO: fix default_root_include_path#20737
Merged
dpiparo merged 1 commit intoroot-project:masterfrom Dec 16, 2025
Merged
ROOTTEST_COMPILE_MACRO: fix default_root_include_path#20737dpiparo merged 1 commit intoroot-project:masterfrom
dpiparo merged 1 commit intoroot-project:masterfrom
Conversation
quotes are escaped by cmake, making the ROOT_INCLUDE_PATH not work, paths with spaces are not supported for some time
pcanal
reviewed
Dec 16, 2025
Contributor
|
I guess you need this backported to 6.38.02, @andresailer? |
Contributor
Author
|
Hi @guitargeek We would need this in the 6.38 branch for running tests. But we don't need this for a release. |
Contributor
|
Okay! It's staged for the backport: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to what was observed here: #19179 (comment)
Quotes are escaped or somehow treated differently by cmake, making the ROOT_INCLUDE_PATH not work, dropping the quotes makes the test pass. Paths with spaces are not supported for some time
This Pull request:
Changes or fixes:
Fixes tests using external vdt:
Related: paths with spaces are no longer supported, as was said here #20098 (comment)
Checklist: