Skip to content

ROOTTEST_COMPILE_MACRO: fix default_root_include_path#20737

Merged
dpiparo merged 1 commit intoroot-project:masterfrom
andresailer:fixTestEnv
Dec 16, 2025
Merged

ROOTTEST_COMPILE_MACRO: fix default_root_include_path#20737
dpiparo merged 1 commit intoroot-project:masterfrom
andresailer:fixTestEnv

Conversation

@andresailer
Copy link
Contributor

@andresailer andresailer commented Dec 16, 2025

Similar to what was observed here: #19179 (comment)

Quotes are escaped or somehow treated differently by cmake, making the ROOT_INCLUDE_PATH not work, dropping the quotes makes the test pass. Paths with spaces are not supported for some time

This Pull request:

Changes or fixes:

Fixes tests using external vdt:

Processing /build/jenkins/workspace/lcg_nightly_pipeline/build/projects/ROOT-HEAD/src/ROOT/HEAD/roottest/scripts/build.C("/build/jenkins/workspace/lcg_nightly_pipeline/build/projects/ROOT-HEAD/src/ROOT/HEAD/roottest/root/io/newstl/TestHelpers.C","","")...
Info in <TUnixSystem::ACLiC>: creating shared library /build/jenkins/workspace/lcg_nightly_pipeline/build/projects/ROOT-HEAD/src/ROOT-HEAD-build/roottest/root/io/newstl/TestHelpers_C.so
In file included from input_line_9:6:
In file included from /build/jenkins/workspace/lcg_nightly_pipeline/build/projects/ROOT-HEAD/src/ROOT/HEAD/roottest/root/io/newstl/TestHelpers.C:1:
/build/jenkins/workspace/lcg_nightly_pipeline/build/projects/ROOT-HEAD/src/ROOT/HEAD/roottest/root/io/newstl/TestHelpers.h:102:24: warning: 'CompMsg' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
   virtual const char* CompMsg(const Helper& icopy) const {
                       ^
/build/jenkins/workspace/lcg_nightly_pipeline/build/projects/ROOT-HEAD/src/ROOT/HEAD/roottest/root/io/newstl/TestHelpers.h:50:24: note: overridden virtual function is here
   virtual const char* CompMsg(const Helper& copy) const {
                       ^
In file included from input_line_9:6:
In file included from /build/jenkins/workspace/lcg_nightly_pipeline/build/projects/ROOT-HEAD/src/ROOT/HEAD/roottest/root/io/newstl/TestHelpers.C:2:
In file included from /build/jenkins/workspace/lcg_nightly_pipeline/build/projects/ROOT-HEAD/src/ROOT/HEAD/roottest/root/io/newstl/TestOutput.h:15:
/build/jenkins/workspace/lcg_nightly_pipeline/build/projects/ROOT-HEAD/src/ROOT-HEAD-build/include/ROOT/RVec.hxx:56:10: fatal error: 'vdt/vdtMath.h' file not found
#include <vdt/vdtMath.h>
         ^~~~~~~~~~~~~~~
Error: /build/jenkins/workspace/lcg_nightly_pipeline/build/projects/ROOT-HEAD/src/ROOT-HEAD-build/bin/rootcling: compilation failure (/build/jenkins/workspace/lcg_nightly_pipeline/build/projects/ROOT-HEAD/src/ROOT-HEAD-build/roottest/root/io/newstl/TestHelpers_C_ACLiC_dict03903bb9b5_dictUmbrella.h)
Error in <ACLiC>: Executing '/build/jenkins/workspace/lcg_nightly_pipeline/build/projects/ROOT-HEAD/src/ROOT-HEAD-build/bin/rootcling "--lib-list-prefix=/build/jenkins/workspace/lcg_nightly_pipeline/build/projects/ROOT-HEAD/src/ROOT-HEAD-build/roottest/root/io/newstl/TestHelpers_C_ACLiC_map" -f "/build/jenkins/workspace/lcg_nightly_pipeline/build/projects/ROOT-HEAD/src/ROOT-HEAD-build/roottest/root/io/newstl/TestHelpers_C_ACLiC_dict.cxx" -I$ROOTSYS/include -I""/build/jenkins/workspace/lcg_nightly_pipeline/build/projects/ROOT-HEAD/src/ROOT-HEAD-build/roottest/root/io/newstl" -I"/build/jenkins/workspace/lcg_nightly_pipeline/install/dev3/Vc/1.4.5/x86_64-el9-gcc15-dbg/include" -I"/build/jenkins/workspace/lcg_nightly_pipeline/install/dev3/vdt/0.4.4/x86_64-el9-gcc15-dbg/include"" -I"/build/jenkins/workspace/lcg_nightly_pipeline/build/projects/ROOT-HEAD/src/ROOT-HEAD-build/etc/" -I"/build/jenkins/workspace/lcg_nightly_pipeline/build/projects/ROOT-HEAD/src/ROOT-HEAD-build/etc//cling" -I"/build/jenkins/workspace/lcg_nightly_pipeline/build/projects/ROOT-HEAD/src/ROOT-HEAD-build/etc//cling/plugins/include" -I"/build/jenkins/workspace/lcg_nightly_pipeline/build/projects/ROOT-HEAD/src/ROOT-HEAD-build/include/" -I"/build/jenkins/workspace/lcg_nightly_pipeline/build/projects/ROOT-HEAD/src/ROOT-HEAD-build/include" -I"/build/jenkins/workspace/lcg_nightly_pipeline/install/dev3/tbb/2022.2.0/x86_64-el9-gcc15-dbg/include" -I"/build/jenkins/workspace/lcg_nightly_pipeline/install/dev3/jsonmcpp/3.12.0/x86_64-el9-gcc15-dbg/include" -D__ACLIC__  "/build/jenkins/workspace/lcg_nightly_pipeline/build/projects/ROOT-HEAD/src/ROOT/HEAD/roottest/root/io/newstl/TestHelpers.C" "/build/jenkins/workspace/lcg_nightly_pipeline/build/projects/ROOT-HEAD/src/ROOT-HEAD-build/roottest/root/io/newstl/TestHelpers_C_ACLiC_linkdef.h"' failed!

Related: paths with spaces are no longer supported, as was said here #20098 (comment)

Support for spaces was already discontinued, see #19795 And #20054

Checklist:

  • tested changes locally

quotes are escaped by cmake, making the ROOT_INCLUDE_PATH not work, paths with spaces are not supported for some time
@bellenot bellenot self-assigned this Dec 16, 2025
Copy link
Member

@pcanal pcanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dpiparo dpiparo merged commit f0459bc into root-project:master Dec 16, 2025
27 of 28 checks passed
@guitargeek
Copy link
Contributor

I guess you need this backported to 6.38.02, @andresailer?

@andresailer andresailer deleted the fixTestEnv branch December 17, 2025 08:17
@andresailer
Copy link
Contributor Author

Hi @guitargeek

We would need this in the 6.38 branch for running tests. But we don't need this for a release.

@guitargeek
Copy link
Contributor

Okay! It's staged for the backport:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants