-
Notifications
You must be signed in to change notification settings - Fork 1.4k
XMLParser: drop unused libm dependency #20822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
guitargeek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much! Just try to keep unrelated changes out of the commit please
312076d to
6afd261
Compare
|
Fixed — thanks for catching that. I’ve amended the commit. I can follow up with separate PRs for other libraries if you think that would be useful, keeping each change focused. |
Test Results 22 files 22 suites 3d 19h 25m 21s ⏱️ Results for commit 6afd261. |
guitargeek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
guitargeek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait that can't be right. Core is a public dependency of XMLParser, because "TObject.h" is included in the public TXMLAttr.h. So the Core dependency needs to be public.
|
Thanks for the review and explanation. I will close this PR. |
This PR removes an unused direct dependency on
libmfromlibXMLParser.The unused dependency was identified via
ldd -uon the official ROOT 6.38.00 binary build for AlmaLinux 9.7.Checklist:
This PR fixes #20731