[v636] Adapt to GCC 8 passing convention for string length#21022
Merged
guitargeek merged 3 commits intoroot-project:v6-36-00-patchesfrom Jan 25, 2026
Merged
[v636] Adapt to GCC 8 passing convention for string length#21022guitargeek merged 3 commits intoroot-project:v6-36-00-patchesfrom
guitargeek merged 3 commits intoroot-project:v6-36-00-patchesfrom
Conversation
According to the `gfortran` argument passing conventions, for any Fortran procedure, the compiler will automatically define a C prototype. This is what we use in `h2root`. Note that for procedures like `HROPEN` that takes string arguments, the signature of the C prototype will have extra arguments for the string lengths, which we also have to include in our forward declaration and usage. However, the type of these was changed with GCC 8 to size_t, so we have to also account for that as recommended in [1]. Otherwise, we get undefined behavor, which causes the `h2root` test to fail on ARM64 with GCC 14. [1] https://gcc.gnu.org/onlinedocs/gfortran/Argument-passing-conventions.html (cherry picked from commit aafddfb) (cherry picked from commit 596cfee)
Follow-up of root-project#20535 (cherry picked from commit 4ac2999) (cherry picked from commit d2a8c79)
Follow-up of root-project@aafddfb (cherry picked from commit 34af31c) (cherry picked from commit 8e90e92)
Test Results 18 files 18 suites 2d 21h 10m 36s ⏱️ For more details on these failures, see this check. Results for commit e21329e. |
guitargeek
merged commit a21773b
into
root-project:v6-36-00-patches
17 of 22 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport the PRs that make things work with GCC 8 on ARM64 on Linux: