Correctly parse the new Windows binaries names (not a change of the website but of the script that builds release pages) #1035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this improvement root-project/root@1998f73 they had names like "root_v6.35.01.win64.vc17.zip". After this improvement, i.e. 2024-11-7, "root_v6.35.01.win64.python311.vc17.zip" i.e. they encode the python version.
bellenot
requested changes
Nov 13, 2024
| return F"macOS {macOSVers} {arch} Xcode {xcodeVers}" | ||
| elif platformCompiler.startswith('win32') or platformCompiler.startswith('win64'): | ||
| regexWin = re.compile(r'^win(32|64)[.](vc[0-9]+)(.debug)?') | ||
| regexWin = re.compile(r'^win(32|64)[.](python3[0-9]+)[.](vc[0-9]+)(.debug)?') |
Member
There was a problem hiding this comment.
We don't build debug anymore. Should we distribute relwithdebinfo? Or do we distribute only release binaries?
Member
Author
There was a problem hiding this comment.
So far we have distributed release binaries: this can be changed if we believe that relwithdebinfo is useful to users. The regex is at the moment harmless, in the sense that in case debug binaries are available, the markdown of the page is generated accordingly. To be 100% correct, one should indeed detect the last part of the binary name and attach it to the name accordingly: release by default, debug in case we have debug binaries and release with debug info (see above necessity criterion)
| else: | ||
| bitArch = "x64" | ||
| return F"Windows Visual Studio {versYear} {bitness}-bit {bitArch} {debug}" | ||
| return F"Windows Visual Studio {versYear} {bitness}-bit {bitArch}{debug}" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this improvement root-project/root@1998f73 they had names like "root_v6.35.01.win64.vc17.zip". After this improvement, i.e. 2024-11-7, "root_v6.35.01.win64.python311.vc17.zip" i.e. they encode the python version.