Skip to content

Treat 'relwithdebinfo' win packages when generating release page #1042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dpiparo merged 1 commit into from
Nov 14, 2024
Merged

Treat 'relwithdebinfo' win packages when generating release page #1042

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions _releases/make-release-page.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ def binaryNameToTitle(filename):

return F"macOS {macOSVers} {arch} Xcode {xcodeVers}"
elif platformCompiler.startswith('win32') or platformCompiler.startswith('win64'):
regexWin = re.compile(r'^win(32|64)[.](python3[0-9]+)[.](vc[0-9]+)(.debug)?')
regexWin = re.compile(r'^win(32|64)[.](python3[0-9]+)[.](vc[0-9]+)(.debug|.relwithdebinfo)?')
matchWin = regexWin.match(platformCompiler)
if not matchWin:
print(F'ERROR: cannot parse Win32 MSVC version for {filename}')
Expand All @@ -270,7 +270,8 @@ def binaryNameToTitle(filename):
if not debug:
debug = ''
else:
debug = ' (debug)'
# The match is ".debug" or ".relwithdebinfo"
debug = ' (' + ('debug' if debug == '.debug' else 'release with debugging information') + ')'
# see https://en.wikipedia.org/wiki/Microsoft_Visual_C%2B%2B#Internal_version_numbering
vcVersYear = {
'vc17': 2022,
Expand Down