Skip to content

Remove the link to Twitter #1048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dpiparo merged 2 commits into from
Nov 23, 2024
Merged

Remove the link to Twitter #1048

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da364a9
Treat 'relwithdebinfo' win packages when generating release page
dpiparo Nov 14, 2024
a1aa71e
Remove Twitter icon
dpiparo Nov 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions _includes/footer/custom.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,7 @@
<img style="width:auto; height:2em;" src="{{'/assets/images/feed.svg' | relative_url}}"></a></div>
<div><font color="#346295" " size="1">Feed</font></div>
</div>
<div style="display:inline-block;"><span style="opacity:0;">space</span></div>
<div style="display:inline-block;">
<div><a href="https://twitter.com/ROOT_Project">
<img style="width:auto; height:2em;" src="{{'/assets/images/twitter.svg' | relative_url}}"></a></div>
<div><font color="#346295" " size="1">Twitter</font></div>
</div></center>
</center>
<hr>

<!-- end custom footer snippets -->
5 changes: 3 additions & 2 deletions _releases/make-release-page.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ def binaryNameToTitle(filename):

return F"macOS {macOSVers} {arch} Xcode {xcodeVers}"
elif platformCompiler.startswith('win32') or platformCompiler.startswith('win64'):
regexWin = re.compile(r'^win(32|64)[.](python3[0-9]+)[.](vc[0-9]+)(.debug)?')
regexWin = re.compile(r'^win(32|64)[.](python3[0-9]+)[.](vc[0-9]+)(.debug|.relwithdebinfo)?')
matchWin = regexWin.match(platformCompiler)
if not matchWin:
print(F'ERROR: cannot parse Win32 MSVC version for {filename}')
Expand All @@ -270,7 +270,8 @@ def binaryNameToTitle(filename):
if not debug:
debug = ''
else:
debug = ' (debug)'
# The match is ".debug" or ".relwithdebinfo"
debug = ' (' + ('debug' if debug == '.debug' else 'release with debugging information') + ')'
# see https://en.wikipedia.org/wiki/Microsoft_Visual_C%2B%2B#Internal_version_numbering
vcVersYear = {
'vc17': 2022,
Expand Down
1 change: 0 additions & 1 deletion assets/images/twitter.svg
View file
Open in desktop

This file was deleted.

Loading