ci: fix missing tag variable in release note generation #537
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
tag="${GITHUB_REF##*/}"to thePrepare the release notestep in.github/workflows/release.yaml.Why
At the time of the v2.3.5 release, the generated release note contained an empty tag placeholder in the download URL, e.g.:
curl -sSL https://github.com/rootless-containers/rootlesskit/releases/download//rootlesskit-$(uname -m).tar.gzThis change ensures that
${tag}is correctly set and expands to the current release tag (e.g.,v3.0.0), so that the release note contains a valid download URL.Example
After this fix, the generated note will correctly include the tag:
curl -sSL https://github.com/rootless-containers/rootlesskit/releases/download/v3.0.0/rootlesskit-$(uname -m).tar.gz | tar Cxzv ~/binQA
Verified in my own sandbox repository: https://github.com/yoshikawa/sandbox/releases/tag/untagged-e0f32bf5925c75582d17
Steps to reproduce: