Conversation
Remove the `string` type hint from the $rootNamespace parameter to match the untyped parent GeneratorCommand::getDefaultNamespace($rootNamespace) signature, resolving the fatal declaration compatibility error in PHP 8. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3
Problem
MakeAbilityCommand::getDefaultNamespacedeclares astringtype on the$rootNamespaceparameter, but the parentIlluminate\Console\GeneratorCommand::getDefaultNamespacehas no type hint. In PHP 8, adding a parameter type in a subclass is a covariance violation, resulting in:Fix
Remove the
stringtype hint from the$rootNamespaceparameter to match the parent signature. The return typestringis kept as PHP allows narrowing return types in subclasses.🤖 Generated with Claude Code