Skip to content

Fix problem with Document class and html() function #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
retlehs merged 5 commits into from
Jan 20, 2026
Merged

Fix problem with Document class and html() function #19

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c5944f1
🩹 Remove XML declaration and comments from HTML output in Document cl…
dustingrofthenumber Dec 5, 2025
e33858d
🩹 Improve comment removal in Document class by using a non-greedy reg…
dustingrofthenumber Dec 9, 2025
1db02e2
🎨 Remove comments
Log1x Jan 4, 2026
70b90c2
🩹 Refactor Document class constructor to simplify XML handling and re…
dustingrofthenumber Jan 12, 2026
21b0aa8
🩹 Remove unused Str import from Document class
dustingrofthenumber Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 4 additions & 33 deletions src/Document.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,26 +14,17 @@ class Document
*/
protected DOMDocument $document;

/**
* The XML encoding tag.
*/
protected string $encoding = '<?xml encoding="UTF-8">';

/**
* Initialize the Document instance.
*/
public function __construct(string $html)
{
$this->document = new DOMDocument;

$this->suppress();
$this->document = new DOMDocument(encoding: 'UTF-8');

$this->document->loadHTML(
Str::start($html, $this->encoding),
\LIBXML_HTML_NOIMPLIED | \LIBXML_HTML_NODEFDTD
$html,
LIBXML_HTML_NOIMPLIED | LIBXML_HTML_NODEFDTD | LIBXML_NOXMLDECL | LIBXML_NOWARNING | LIBXML_NOERROR
);

$this->clear();
}

/**
Expand Down Expand Up @@ -69,27 +60,7 @@ public function xpath(string $expression): DOMNodeList
*/
public function html(): string
{
return trim(substr($this->document->saveHTML(), 23));
}

/**
* Suppress the XML errors.
*/
protected function suppress(): self
{
libxml_use_internal_errors(true);

return $this;
}

/**
* Clear the XML errors.
*/
protected function clear(): self
{
libxml_clear_errors();

return $this;
return trim($this->document->saveHTML());
}

/**
Expand Down
Loading