Skip to content

Conversation

@retlehs
Copy link
Member

@retlehs retlehs commented Aug 8, 2025

This PR adds code quality checks to the CI workflow and fixes all existing linting issues

Changes

1. CI Workflow Enhancements

  • Added gofmt check to enforce consistent Go formatting
  • Added golangci-lint for comprehensive code analysis
  • Added go mod tidy check to ensure dependencies are properly maintained

2. Code Formatting

  • Applied gofmt -s to fix import ordering and code style across 13 files

3. Linting Fixes

  • Fixed 40+ golangci-lint issues including:
    • Unchecked error returns (errcheck)
    • Ineffectual variable assignments (ineffassign)
    • Removed unused functions and variables
    • Fixed printf-style function issues (staticcheck)
    • Simplified code per gosimple recommendations
    • Fixed test helper functions

🤖 Generated with Claude Code

Co-Authored-By: Claude [email protected]

retlehs and others added 3 commits August 8, 2025 14:00
- Fix unchecked error returns (errcheck)
- Fix ineffectual assignments (ineffassign)
- Remove unused functions and variables
- Fix printf-style function issues (staticcheck)
- Simplify code per gosimple recommendations
- Update mock detector to use current directory to avoid chdir errors in tests

All golangci-lint checks now pass.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@retlehs retlehs requested a review from swalkinshaw August 8, 2025 18:44
@retlehs retlehs self-assigned this Aug 8, 2025
@retlehs retlehs merged commit 0224e3a into master Aug 8, 2025
8 checks passed
@retlehs retlehs deleted the ci-updates branch August 8, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants