Conversation
swalkinshaw
reviewed
Mar 16, 2026
Remove the chi dependency in favor of Go 1.22+ ServeMux patterns and a small set of stdlib middleware (Recoverer, RealIP, TimeoutHandler). Drop ADMIN_ALLOW_CIDR and RequireAllowedIP — production already disabled IP restriction. Admin access relies solely on in-app auth. Keep TRUST_PROXY so clientIP() works behind Caddy for rate limiting and telemetry dedupe. Co-Authored-By: Scott Walkinshaw <scott.walkinshaw@gmail.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
RealIP is needed for login rate limiting and telemetry dedupe behind Caddy. No reason to gate it behind a config flag — the app is always proxied in production, and in dev the headers aren't present so RemoteAddr passes through unchanged. Co-Authored-By: Scott Walkinshaw <scott.walkinshaw@gmail.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The global http.TimeoutHandler replaced the ResponseWriter with a buffering writer that doesn't implement http.Flusher, breaking /admin/logs/stream in two ways: 1. The SSE handler's w.(http.Flusher) assertion always failed (500) 2. The previous noTimeout(context.WithoutCancel) couldn't bypass TimeoutHandler since it replaces the writer, not just the context Fix: path-based timeout bypass that skips http.TimeoutHandler entirely for streaming endpoints, preserving the original ResponseWriter. Add Flush()/Unwrap() to statusRecorder so Flusher propagates through the custom 404 layer. Remove the broken context-key noTimeout mechanism. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
net/http.ServeMux— removes the only routing dependencyADMIN_ALLOW_CIDRandRequireAllowedIP(production already hadadmin_allow_cidr: "")TRUST_PROXYwith a stdlibRealIPmiddleware soclientIP()works behind Caddy for login rate limiting and download dedupeappHandlerwrapper that handles sitemap-packages prefix routing (can't be expressed as a ServeMux pattern) and custom 404 templates without suppressing stdlib 405 behavior or swallowing handler-generated 404sTest plan
go test ./...passesgolangci-lint run ./...— 0 issuesgo vet ./...passesmake smokeend-to-end testPOST /healthreturns 405 (not 404)/sitemap-packages-0.xmlroutes correctly🤖 Generated with Claude Code