Conversation
swalkinshaw
force-pushed
the
search-use-fts
branch
2 times, most recently
from
06076d1 to
1cb8f7d
Compare
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ea4b6b9e24
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
internal/http/handlers.go
Outdated
| where += " AND id IN (SELECT rowid FROM packages_fts WHERE packages_fts MATCH ?)" | ||
| args = append(args, ftsQuery(f.Search)) |
There was a problem hiding this comment.
If search contains only whitespace (for example ?search=%20%20), ftsQuery returns an empty string and this path still executes packages_fts MATCH ? with "", which SQLite rejects (fts5: syntax error near ""). That turns a harmless user input into a 500 for both public and admin package listings; guard on a trimmed/tokenized query before adding the MATCH clause.
Useful? React with 👍 / 👎.
swalkinshaw
force-pushed
the
search-use-fts
branch
from
ea4b6b9 to
e1a47f6
Compare
2 participants
No description provided.