Merged
Conversation
Tighten version validation regex to only allow Composer-compatible pre-release suffixes (alpha, beta, rc, etc). The previous regex accepted -dev1 and similar non-Composer suffixes which Composer's VersionParser rejects. Add defense-in-depth filtering in the builder so stale DB rows with invalid versions can't reach artifacts. Closes #17 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
retlehs
changed the title
Member
Author
Affected packages: 98 packages with 386 invalid versions
|
|
thanks @retlehs 🙌 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
suffixes (
alpha,beta,rc,dev,stable, etc). Rejects invalid formslike
-dev1,-free, and trailing-dot prereleases (e.g.-beta.) that triggerComposer
Invalid version stringerrors.NormalizeVersions()call in the builder so stale DB rowswith invalid versions never reach
p/orp2/artifacts.3.1.0-dev1),trailing-dot edge cases, and samples from the Wordfence invalid version corpus.
Closes #17
Test plan
go test ./...passeswp-plugin/elementorstrips all 87-devNversions while preserving all valid versions
update+build+ deploy artifacts to purge invalidversions from production metadata
🤖 Generated with Claude Code