Server: Allow second SIGINT / SIGTERM to force exit#31
Merged
swalkinshaw merged 1 commit intoroots:mainfrom Mar 18, 2026
Merged
Server: Allow second SIGINT / SIGTERM to force exit#31swalkinshaw merged 1 commit intoroots:mainfrom
SIGINT / SIGTERM to force exit#31swalkinshaw merged 1 commit intoroots:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the HTTP server shutdown flow to use a context-based signal notification mechanism instead of a dedicated signal channel, aligning shutdown triggering with context.Context cancellation semantics.
Changes:
- Replaced
signal.Notify+quitchannel withsignal.NotifyContext(...). - Updated shutdown logging to record a context-derived value on cancellation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| case sig := <-quit: | ||
| a.Logger.Info("shutting down", "signal", sig.String()) | ||
| case <-sigCtx.Done(): | ||
| a.Logger.Info("shutting down", "cause", context.Cause(sigCtx)) |
| a.Logger.Info("shutting down", "signal", sig.String()) | ||
| case <-sigCtx.Done(): | ||
| a.Logger.Info("shutting down", "cause", context.Cause(sigCtx)) | ||
| stop() |
tangrufus
changed the title
SIGINT & SIGTERM to force exitSIGINT / SIGTERM to force exit
Before: 1. Boot the server 2. Press `Ctrl + C` once to trigger graceful shutdown 3. Press `Ctrl + C` again. This has no effect. You must wait for the server to shut down After: 1. Boot the server 2. Press `Ctrl + C` once to trigger graceful shutdown 3. Press `Ctrl + C` again to force exit immediately
swalkinshaw
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After: