Fix untracked db changes CI check#1003
Merged
JulianPasquale merged 7 commits intomainfrom Mar 11, 2025
Merged
Conversation
PerezIgnacio
approved these changes
Mar 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
When we add a new migration we expect the CI to check that the
db/schema.rbhas been updated accordingly, and that's why we have a step to "Check for untracked changes in schema.rb".As evidence you can see this CI execution. In this commit a new table was added. Since the CI is using the schema to setup the database, but that file was not updated, the check for untracked changes step was not failing.
By running a migrate step after loading the schema, we ensure all the differences in the schema or models annotations are applied.
Note: I'm also changing the order of the steps so the untracked changes check is performed before the assets precompile to save some time in case that fails.