Add tests for repository distribution logic

Author: gonzaM

spec/factories/events/pull_requests.rb

@@ -47,7 +47,7 @@
     size { Faker::Number.within(range: 0..10_000) }
     state { 'open' }
     html_url { 'https://github.com/Codertocat/Hello-World/pull/2' }
-    opened_at { Faker::Date.between(from: 1.month.ago, to: Time.zone.now) }
+    opened_at { Faker::Time.between(from: 1.month.ago, to: Time.zone.now) }
     locked { false }
     draft { false }
     repository

spec/services/builders/distribution/pull_requests/review_coverage_repository_spec.rb

@@ -0,0 +1,114 @@
+require 'rails_helper'
+
+RSpec.describe Builders::Distribution::PullRequests::ReviewCoverageRepository do
+  describe '.call' do
+    let(:from) { 4.weeks.ago }
+    let(:to) { Time.zone.now }
+    let(:repository_one) { create(:repository) }
+    let(:repository_two) { create(:repository) }
+
+    let!(:first_pull_request) do
+      create(:pull_request, :merged,
+             repository: repository_one,
+             html_url: 'test_pr_url_one',
+             merged_at: 6.hours.ago)
+    end
+
+    let!(:second_pull_request) do
+      create(:pull_request, :merged,
+             repository: repository_two,
+             html_url: 'test_pr_url_two',
+             merged_at: 14.hours.ago)
+    end
+
+    let!(:third_pull_request) do
+      create(:pull_request, :merged,
+             repository: repository_one,
+             html_url: 'test_pr_url_three',
+             merged_at: 26.hours.ago)
+    end
+
+    before do
+      first_pull_request.review_coverage.update!(coverage_percentage: 0.25)
+      second_pull_request.review_coverage.update!(coverage_percentage: 0.75)
+      third_pull_request.review_coverage.update!(coverage_percentage: 0.50)
+    end
+
+    context 'with correct params' do
+      subject do
+        described_class.call(
+          repository_name: repository_one.name,
+          from: from,
+          to: to
+        )
+      end
+
+      it 'returns data for 0-25% coverage' do
+        expect(subject).to have_key('20-40')
+        expect(subject['20-40'].first[:value]).to eq(25.0)
+      end
+
+      it 'returns data for 50-75% coverage' do
+        expect(subject).to have_key('40-60')
+        expect(subject['40-60'].first[:value]).to eq(50.0)
+      end
+
+      it 'does not return data for 25-50% coverage' do
+        expect(subject).not_to have_key('10-20')
+      end
+    end
+
+    context 'when pull request has html_url attribute nil' do
+      let!(:pull_request_html_url_nil) do
+        create(:pull_request, :merged,
+               repository: repository_one,
+               html_url: nil,
+               merged_at: 40.hours.ago)
+      end
+
+      before do
+        pull_request_html_url_nil.review_coverage.update!(coverage_percentage: 0.90)
+      end
+
+      subject do
+        described_class.call(
+          repository_name: repository_one.name,
+          from: from,
+          to: to
+        )
+      end
+
+      it 'does not add the pull request to the data' do
+        expect(subject).not_to have_key('60-80')
+      end
+    end
+
+    context 'when pull request belongs to ignored user' do
+      let(:ignored_user) { create(:user, login: 'ignored_user') }
+      let!(:setting) { create(:setting, key: 'ignored_users', value: ignored_user.login) }
+
+      let!(:ignored_pull_request) do
+        create(:pull_request, :merged,
+               repository: repository_one,
+               merged_at: 6.hours.ago,
+               owner: ignored_user)
+      end
+
+      before do
+        ignored_pull_request.review_coverage.update!(coverage_percentage: 0.25)
+      end
+
+      subject do
+        described_class.call(
+          repository_name: repository_one.name,
+          from: from,
+          to: to
+        )
+      end
+
+      it 'does not include pull requests from ignored users' do
+        expect(subject['20-40'].pluck(:html_url)).not_to include('ignored_pr_url')
+      end
+    end
+  end
+end

spec/services/metrics/review_coverage/per_repository_spec.rb

@@ -0,0 +1,66 @@
+require 'rails_helper'
+
+RSpec.describe Metrics::ReviewCoverage::PerRepository do
+  describe '.call' do
+    let(:subject) { described_class.call(repository.id) }
+    let(:repository) { create(:repository) }
+    let(:beginning_of_day) { Time.zone.today.beginning_of_day }
+    let(:entity_type) { 'Repository' }
+    let(:metric_name) { :review_coverage }
+
+    context 'when there is available data' do
+      before do
+        pull_request1 = create(
+          :pull_request,
+          :merged,
+          repository: repository,
+          merged_at: beginning_of_day + 1.hour
+        )
+        pull_request2 = create(
+          :pull_request,
+          :merged,
+          repository: repository,
+          merged_at: beginning_of_day + 3.hours
+        )
+        pull_request1.review_coverage.update!(coverage_percentage: 80.0)
+        pull_request2.review_coverage.update!(coverage_percentage: 90.0)
+      end
+
+      it 'returns the metric' do
+        metrics = subject
+        expect(metrics.count).to eq 1
+      end
+
+      it 'returns the average value' do
+        metric = subject.first
+        expect(metric.value).to eq 85.0
+      end
+
+      context 'when interval is set' do
+        let(:interval) { 4.weeks.ago.beginning_of_week..Time.current.end_of_week }
+        let(:subject) { described_class.call(repository.id, interval) }
+
+        before do
+          pull_request = create(
+            :pull_request,
+            :merged,
+            repository: repository,
+            merged_at: 5.weeks.ago
+          )
+          pull_request.review_coverage.update!(coverage_percentage: 85.0)
+        end
+
+        it 'does not change metric value' do
+          metric = subject.first
+          expect(metric.value).to eq 85.0
+        end
+      end
+    end
+
+    context 'when no data is available' do
+      it 'returns no metrics' do
+        expect(subject).to be_empty
+      end
+    end
+  end
+end