Skip to content

Fix Review Coverage when the PR has no files #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gonzaM merged 2 commits into from
Aug 12, 2025
Merged

Fix Review Coverage when the PR has no files #606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49cdd71
Fix Review Coverage when the PR has no files
gonzaM Aug 12, 2025
86f35f6
Fix linter issues
gonzaM Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/services/builders/review_coverage.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ def files_with_comments_count
end

def coverage_percentage
return 0 if total_files.zero?

(files_with_comments_count.to_f / total_files).round(2)
end

Expand Down
10 changes: 10 additions & 0 deletions spec/services/builders/review_coverage_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,5 +38,15 @@
expect(review_coverage.coverage_percentage).to eq(0)
end
end

context 'when the pull request has no files' do
let(:total_files) { 0 }

it 'creates a review coverage with zero coverage' do
review_coverage = subject
expect(review_coverage.total_files_changed).to eq(0)
expect(review_coverage.coverage_percentage).to eq(0)
end
end
end
end
Loading