Add zero comments percetage #609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonzaM
requested review from
rodrieiz and
santib
and removed request for
a team
santib
reviewed
Sep 29, 2025
app/services/builders/chartkick/repository_distribution_data.rb
Outdated
Show resolved
Hide resolved
santib
reviewed
Sep 29, 2025
app/services/builders/chartkick/repository_distribution_data_metrics/review_coverage.rb
Outdated
Show resolved
Hide resolved
santib
approved these changes
Sep 29, 2025
Member
santib
left a comment
santib
left a comment
There was a problem hiding this comment.
👮
left a couple of comments so this review isn't considered a 0comments review 🤣
Co-authored-by: Santiago Bartesaghi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add percentage of PRs with zero comments to Review Coverage
This PR enhances Review Coverage by introducing a new metric: the percentage of PRs with zero comments.
Motivation
The current review coverage average number provides limited value, as it does not clearly show how much reviewing is actually happening. To make this more actionable, we add the percentage of PRs with zero comments, emphasizing that what matters is ensuring each PR receives some level of review, rather than the total number of comments, which does not directly reflect quality.
Summary
interval_metrics.Changes
Note
The "department metrics" are no longer used, which is why the "success rate" was not updated and the test was removed. In a future PR, the plan is to remove the "Department" logic altogether to simplify the code.