Draft
Conversation
maelle
commented
Feb 25, 2025
|
|
||
|
|
||
|
|
||
| - [ ] Follow [editor.md](editor.md) checklist. |
Contributor
Author
There was a problem hiding this comment.
and I'm sure others have nice tips / items for this list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maybe I'm too set in my ways, but I don't find the
index.Rmdthat useful. It's not how I'd explore the package.What I'm thinking of are possible checklist items but in that case should they be in the editor template?
I also wonder if the package should create a project for the editor checks. I would prefer to only fork and clone the package under review, and have my editor response stored in a gitignored, Rbuildignored file.
One last thing: I wonder whether an IDE extension (of Positron for instance) could help with permalinking code lines that one notices locally.
Thoughts?