add simplify argument to eml_get#304
Open
jeanetteclark wants to merge 3 commits intoropensci:masterfrom
jeanetteclark:master
Open
add simplify argument to eml_get#304jeanetteclark wants to merge 3 commits intoropensci:masterfrom jeanetteclark:master
eml_get#304jeanetteclark wants to merge 3 commits intoropensci:masterfrom
jeanetteclark:master
Conversation
Member
|
@amoeba looks like check fails for unrelated issue with set_TextType -- any ideas on that? |
Member
|
ping? waiting on resolving the potential test error here before we proceed... |
Collaborator
|
I reproduced locally and I think this isn't just a spurious test failure and that we should make sure to look into it before merging. @jeanetteclark do you wanna have a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses what I brought up in issue #303
I decided to keep the default value to
FALSEmainly to avoid having to deal with too many breaking changes.