fix: Establish compatibility with upcoming DBI 1.3.0#197
Open
krlmlr wants to merge 3 commits intoropensci:mainfrom
Open
fix: Establish compatibility with upcoming DBI 1.3.0#197krlmlr wants to merge 3 commits intoropensci:mainfrom
krlmlr wants to merge 3 commits intoropensci:mainfrom
Conversation
Contributor
Author
|
Re-reading my request, it does sound a bit pushy. I didn't mean it to be. Thank you for your support! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DBI 1.3.0 adds support for OpenTelemetry tracing. See tidyverse/tidyverse.org#786 for context.
We change the definition of generics including
dbConnect(). This package currently relies on the generic being of class"standardGenericWithTrace"after establishing the trace, in DBI 1.3.0 this will be"nonstandardGenericFunctionWithTrace"(from tests on my system).Checks are currently running with CRAN DBI, I'll add a "Remotes" in the next commit to also check against dev DBI. I'll also introduce a new function for this inheritance check.
This is the only true breakage for the upcoming DBI release, as far as CRAN is concerned.
@jonkeane: Would you be able to submit a micro-update with this change soon-ish? Thanks!