Fix test "metadata is maintained (gdalraster SOZip)" for GDAL < 3.7#174
Closed
ctoney wants to merge 1 commit intoropensci:mainfrom
Closed
Fix test "metadata is maintained (gdalraster SOZip)" for GDAL < 3.7#174ctoney wants to merge 1 commit intoropensci:mainfrom
ctoney wants to merge 1 commit intoropensci:mainfrom
Conversation
Author
|
Sorry, I had paused for a while to look at the warnings I was getting from the test set, and didn't check back to see you had this covered in the meantime. This can be ignored obviously. Nice work on the package. |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR skips the test that uses
gdalraster::addFilesInZip()if GDAL < 3.7.0. Currently showing as an error on CRAN at https://cran.r-project.org/web/checks/check_results_geotargets.html:In case it's of interest, I also see a warning from this test that comes from a GDAL warning:
Since that test uses an HFA file type, it may be due to: OSGeo/gdal#12323
I'm using GDAL 3.10.3 on Ubuntu.