Open
Conversation
All tests passed without changes before this commit. Old functions still work
Feature refers to represented entities represented by OSM objects. Tags are the attributes of OSM objects that characterize the features.
All tests passed without changes before this commit. Old functions still work
jmaspons
force-pushed
the
rename_query_builders
branch
from
cb9ac1a to
cf5500b
Compare
mpadge
requested changes
Mar 19, 2026
Member
mpadge
left a comment
mpadge
left a comment
There was a problem hiding this comment.
Thanks @jmaspons I'm going to request changes here just so that I'll see when you've re-requested review. The changes I've requested are described in #255 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename
add_osm_feature()->filter_osm_tags()andadd_osm_features()->add_osm_tags(). Keep the old alias working and silent for now, the old names will be DEPRECATED in a future version and will throw warnings.Make docs, parameters and variable names consistent for tags / features use. Feature refers to entities from the real world represented by OSM objects. Tags are the attributes of OSM objects that characterize the features.
Discussed in #255