Skip to content

fix: path#18

Closed
maelle wants to merge 1 commit intomainfrom
tests
Closed

fix: path#18
maelle wants to merge 1 commit intomainfrom
tests

Conversation

@maelle
Copy link
Member

@maelle maelle commented Oct 9, 2025

Not the complete PR I had in mind because I'm getting some trouble with terra.

Anyway the problem is that if the path is

#' dat <- read.csv(system.file("extdata",
#'                             "ssarp_Example_Dat_Dat.csv",
#'                             package = "ssarp"))

then on Ubuntu it won't be found because the filename is actually SSARP_Example_Dat_Dat.csv.

So the fix would be to go over those examples that fail, correcting the path to account for case-sensitivity, running document().

(my issue is that rlang things terra isn't installed but I have just installed it!)

@maelle maelle requested a review from kmartinet October 9, 2025 12:56
@kmartinet
Copy link
Collaborator

Thank you so much for catching this, @maelle ! I chose to rename the file to ssarp_Example_Dat.csv since that was its intended name. I also found a capitalization mismatch in some uses of Patton_Anolis_Trimmed.tree that I fixed. R-CMD-check is officially passing as of the most recent commit!

@kmartinet kmartinet closed this Oct 10, 2025
@maelle
Copy link
Member Author

maelle commented Oct 13, 2025

Yay!! What is the pkgcheck's warning?

@kmartinet
Copy link
Collaborator

The pkgcheck warnings were Package has no continuous integration checks and R CMD check found 1 warning. I made a few edits today and now pkgcheck is succeeding again!!

The R CMD check warning was: LaTeX errors when creating PDF version. This typically indicates Rd problems. LaTeX errors found: ! LaTeX Error: Unicode character ό (U+03CC) not set up for use with LaTeX. See the LaTeX manual or LaTeX Companion for explanation. I fixed this today by ensuring that original uses of ό were updated to the proper ó (this must have originally been a copy/paste issue in one of my text editors).

The CI warning is still confusing to me, but maybe it was flagged because R CMD check had a warning?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants