Conversation
adamhsparks
approved these changes
Dec 16, 2025
Member
adamhsparks
left a comment
There was a problem hiding this comment.
Nice! I'm impressed by the vignette. You've put a lot of work into this, it's a nice addition. Well done!!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for the Norwegian Meteorological Institute (METNO) Weather API. It includes new functions for fetching and aggregating METNO forecast data, updates to documentation and examples, and updates to API key handling and validation. The changes enable users to access and process 9-day weather forecasts from METNO, improve API key management, and bring the package documentation and infrastructure up to date with the new features.
Key changes:
METNO API integration:
get_metno_forecast,get_metno_daily_forecast,metno_get_dominant_symbol,metno_resample_data_table, andmetno_timeseries_to_data_tablefor accessing and processing METNO weather forecast data.get_metno_daily_forecast, providing users with summarised daily weather information.API key handling and validation:
get_key()to support the "METNO" service and added.set_metno_key()for user guidance..is_valid_email_metno_api_key()to validate that the METNO API key is a valid email address, as validation for the SILO API key.Other updates:
NAMESPACEto export new METNO-related functions and import required packages (jsonlite,lubridate,crul)..Rbuildignorefor proper package building.%||%for cleaner default argument handling in internal functions.