Tweak how httr2 mocking function is set#141
Merged
sckott merged 1 commit intoropensci:mainfrom Apr 14, 2025
hadley:httr2-mock-set
Merged
Tweak how httr2 mocking function is set#141sckott merged 1 commit intoropensci:mainfrom hadley:httr2-mock-set
sckott merged 1 commit intoropensci:mainfrom
hadley:httr2-mock-set
Conversation
There's no need to use `local_` here since you're not setting it locally and this avoids a slightly confusing message from withr: ```R webmockr::enable() #> CrulAdapter enabled! #> HttrAdapter enabled! #> Httr2Adapter enabled! #> Setting global deferred event(s). #> i These will be run: #> * Automatically, when the R session ends. #> * On demand, if you call `withr::deferred_run()`. #> i Use `withr::deferred_clear()` to clear them without executing. ``` (In principle, it would be better if webmockr could restore the previous state prior to its mocking, but it's not a big deal given that there are very few other tools that do web mocking).
Collaborator
|
makes sense and i like that message disappearing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's no need to use
local_here since you're not setting it locally and this avoids a slightly confusing message from withr:(In principle, it would be better if webmockr could restore the previous state prior to its mocking, but it's not a big deal given that there are very few other tools that do web mocking).
Description
Related Issue
Example